search

bluesky-social / atproto-website

https://atproto.com
Other
215 stars 138 forks source link

Lexicon specs are missing, links 404 #294

Open str4d opened 5 months ago

str4d commented 5 months ago

Steps to reproduce

  1. Navigate to the documentation for a specific lexicon (e.g. https://atproto.com/guides/applications#appbskyfeedpost)
  2. Click on its name (which in the above case navigates to https://atproto.com/lexicons/app-bsky)

Expected

I should see the app.bsky lexicon specification (ideally for app.bsky.feed.post in the above example).

Actual

A very pretty 404 error page.

str4d commented 5 months ago

The bad links are here: https://github.com/bluesky-social/atproto-website/blob/d604684c94b8cd8bd655d3001167a43676967278/content/guides/applications.md?plain=1#L105

The lexicon specifications they linked to were removed in #283.

str4d commented 5 months ago

There are existing redirects for legacy lexicon subpages to the (now-removed) combined lexicon pages, that would also need to be updated: https://github.com/bluesky-social/atproto-website/blob/d604684c94b8cd8bd655d3001167a43676967278/next.config.js#L36-L105

lucalves commented 4 months ago

Hello, I opened PR #295 removing the links and fixing the redirects that caused the 404 error. Let's wait for the review.

bnewbold commented 1 month ago

I think with the above PR these are resolved. We should still update/replace these pages to not have any lexicon links, or to link to https://docs.bsky.app, but I think the urgent bug is resolved.