bluesky-social / atproto

Social networking technology created by Bluesky
Other
5.77k stars 406 forks source link

Entryway PDS resolves handles after account migration #2280

Open goeo- opened 3 months ago

goeo- commented 3 months ago

Describe the bug

I migrated my account did:plc:f5ejbog3ostso47er2y5ugbl to my own pds, then changed the handle to on-plc.goeo.lol. That account has held the handle genco.me before.

I even deactivated the account on the bluesky servers, but when I resolveHandle genco.me on bsky.social, it still resolves to my old did:plc.

To Reproduce

Steps to reproduce the behavior:

  1. https://bsky.social/xrpc/com.atproto.identity.resolveHandle?handle=genco.me
  2. https://bsky-debug.app/handle?handle=genco.me

Expected behavior

Nothing should be resolving genco.me as anything but did:web:genco.me.

goeo- commented 3 months ago

i'd like to try to fix this, but it's unclear what software the entryway runs (some branch?) - i think this effects all migrated accounts, and is still causing problems like https://bsky.app/profile/mackuba.eu/post/3kofkqrqiez2l

snarfed commented 2 months ago

I think I'm seeing this issue too, with accounts on my third party federated PDS.

@snarfed.indieweb.social.ap.brid.gy is an example: the first time you load eg https://bsky.app/profile/snarfed.indieweb.social.ap.brid.gy , it shows an Oops! Unable to resolve handle error. Behind the scenes, it's hitting https://bsky.social/xrpc/com.atproto.identity.resolveHandle?handle=snarfed.indieweb.social.ap.brid.gy , which always 400s with Unable to resolve handle. When I click Try again, it hits https://morel.us-east.host.bsky.network/xrpc/com.atproto.identity.resolveHandle?handle=snarfed.indieweb.social.ap.brid.gy , which correctly returns that account's DID, so the profile loads.

@goeo- this seems similar to what you're seeing. https://bsky.social/xrpc/com.atproto.identity.resolveHandle?handle=genco.me returns your old did:plc, but https://morel.us-east.host.bsky.network/xrpc/com.atproto.identity.resolveHandle?handle=genco.me correctly returns did:web:genco.me.

snarfed commented 2 months ago

^ thanks @mackuba for the great sleuthing!

snarfed commented 2 months ago

https://github.com/bluesky-social/social-app/pull/3620 hopefully fixes this, and it's merged, so the next entryway release should do it 🤞.

Than you @mary-ext!!!

goeo- commented 2 months ago

i would leave the issue open until the entryway starts resolving my handle correctly, or removes the endpoint, but this should fix the problem, for sure!

snarfed commented 1 month ago

Looks like this might be fixed...? Federated profiles are now all loading for me on bsky.app the first time!

snarfed commented 1 month ago

...although @goeo- reports that this only seems fixed for federated did:plcs, not for did:webs like his. The client side PR doesn't fix the entryway's stale caching, it's just a band-aid that avoids it altogether.