search

bluesky-social / atproto

Social networking technology created by Bluesky
Other
5.78k stars 409 forks source link

Inconsistent deactivated repo behavior between com.atproto.repo.* methods #2617

Open elfprince13 opened 1 week ago

elfprince13 commented 1 week ago

Describe the bug

Currently, accessing a deactivated repo through describeRepo returns a RepoDeactivated with message Repo has been deactivated, accessing it through listRecords returns an InvalidRequest with message Could not find repo, and perhaps most notably accessing it through getRecord returns valid post data if you know a valid rkey (for example from traversing old threads).

To Reproduce

Find a thread with a reply from a deactivated account and access the rkey of that post.

Expected behavior

Given the same DID, all three methods should presumably either succeed or fail with the same error message.

Details

Poking about the API with HTTP GET requests.

Additional context

Not going to post relevant URLs publicly but feel free to message me privately if you want an example.

bnewbold commented 1 week ago

@elfprince13 the getRecord behavior should be fixed by https://github.com/bluesky-social/atproto/pull/2620, which has been rolled out in production. Can you confirm it fixes that aspect of the problem for you?

We can keep this issue open to track the listRecords part, I think we might need to add some error types to the response Lexicon for that one.

elfprince13 commented 3 days ago

@bnewbold - the querying that was returning a post before is now returning "repo not found" which isn't quite consistent, but it is at least keeping deactivated posts contained. =)