search

bluesky-social / atproto

Social networking technology created by Bluesky
Other
7.27k stars 513 forks source link

Appview: temp fix for bad pinned post values #2875

Closed devinivy closed 1 month ago

devinivy commented 1 month ago

Looks like a client or bug may have been responsible for some bad pinned post values on profiles, causing some responses to be invalid. This should set things straight while it gets worked out.

mary-ext commented 1 month ago

Are the bad values because someone's setting a pinnedPost with a string rather than a strongRef? It seems like we're clashing with a rather popular unspecced field rather than a bug

e.g. Klearsky introduced pinnedPost?: string to profiles since end of April, with Tokimeki and Hagoromo following suit, way before we did https://github.com/mimonelu/klearsky/commit/18628cf91c9aaf244ca37f2ce98bcdb3cf2ee02a

bnewbold commented 1 month ago

@mary-ext that does seem to be the issue. none of us (at bluesky) were aware that other folks were using the exact same field name in a different way.

an interesting case-study in lexicon evolution and governance! should probably do a write-up / post-mortem and have better guidance on folks doing "extensions" can chose field names to avoid conflict like this going forward. eg, use an NSID as the field name, or add some non-conflicting string prefix to reduce the chance of a collision.