search

bluesky-social / atproto

Social networking technology created by Bluesky
Other
6.62k stars 465 forks source link

Remove "Failed to create bin" warnings from pnpm install #3011

Open trivikr opened 2 hours ago

trivikr commented 2 hours ago

Is your feature request related to a problem? Please describe.

The following warnings are shown when running make deps

...
 WARN  Failed to create bin at /Users/trivikram/workspace/atproto/packages/api/node_modules/.bin/lex. ENOENT: no such file or directory, open '/Users/trivikram/workspace/atproto/packages/lex-cli/dist/index.js'
 WARN  Failed to create bin at /Users/trivikram/workspace/atproto/packages/bsky/node_modules/.bin/lex. ENOENT: no such file or directory, open '/Users/trivikram/workspace/atproto/packages/lex-cli/dist/index.js'
 WARN  Failed to create bin at /Users/trivikram/workspace/atproto/packages/bsky/node_modules/.bin/pds. ENOENT: no such file or directory, open '/Users/trivikram/workspace/atproto/packages/pds/dist/bin.js'
 WARN  Failed to create bin at /Users/trivikram/workspace/atproto/packages/dev-env/node_modules/.bin/bsky. ENOENT: no such file or directory, open '/Users/trivikram/workspace/atproto/packages/bsky/dist/bin.js'
...

Describe the solution you'd like

Warnings not shown when running make deps

trivikr commented 2 hours ago

I did some search online, and presence of sharp@0.32.x might be causing this. Refs: https://github.com/misskey-dev/misskey/issues/13383#issuecomment-1951330255

From lockfile, I noticed that sharp@0.32.6 is still being imported https://github.com/bluesky-social/atproto/blob/c34426fc55e8b9f28d9b1d64eab081985d1b47b5/pnpm-lock.yaml#L12616-L12620

That appears to be from @atproto/pds@0.3.0-entryway.3 dependency

It seems to be used in test file https://github.com/bluesky-social/atproto/blob/c34426fc55e8b9f28d9b1d64eab081985d1b47b5/packages/pds/tests/entryway.test.ts#L10