search

bluesky-social / atproto

Social networking technology created by Bluesky
Other
6.88k stars 486 forks source link

Remove author blocks from getLikes #3012

Open rafaelbsky opened 6 days ago

rafaelbsky commented 6 days ago

This removes 3rd-party blocks from getLikes.

So a viewer seeing the likes in a post will not see the likes by users the viewer blocked and by users the post author blocked.

rafaelbsky commented 14 hours ago

Thanks @devinivy , I got confused about some things and the state of the PR showed it.

I also noticed another problem, which I fixed.

In 2dc504aec16d4b6be3d4ac4c39988a06368b00d4 I added a test that should capture the bug. But the test was wrong. The second case I added was supposed to be run as a non-author, but I did run it as the author (alice). I (hope I) fixed that test in b4d7b09806a11e7a0fb5eeef1998743e3e429a3b.