bluesky-social / atproto

Social networking technology created by Bluesky
Other
6.48k stars 452 forks source link

Validate CIDs passed to PDS xrpc methods #456

Closed devinivy closed 1 year ago

devinivy commented 1 year ago

There are a handful of cid parameters and inputs to the PDS xrpc methods. We should consider validating these as CIDs, otherwise fail the request with a 400. In some cases currently CID.parse() may be called on them, causing an error to be thrown that turns into a 500.

dholms commented 1 year ago

fixed w new cid format

https://github.com/bluesky-social/atproto/pull/658