search

bluesky-social / feed-generator

ATProto Feed Generator Starter Kit
MIT License
919 stars 329 forks source link

move app-password to dotenv file #50

Open nickdepinet opened 1 year ago

nickdepinet commented 1 year ago

This is a simple PR moving the app password to be pulled from the dotenv file for the publishFeedGen script. This will help prevent accidental password checkins, since the dotenv file is by default included in the gitignore.

nickdepinet commented 1 year ago

@dholms

mackuba commented 1 year ago

Would it maybe make more sense to just read it from STDIN (in some password entering mode that hides typed characters)? Publishing a feed is something that will usually only be done once and then maybe a couple of times at most when editing the name/description, so even having it in an .env file in plain text feels like unnecessary risk for basically zero added convenience. (I have no idea how to do this in Node)

mackuba commented 1 year ago

Something like this https://www.npmjs.com/package/password-prompt