search

bluesky-social / feed-generator

ATProto Feed Generator Starter Kit
MIT License
919 stars 329 forks source link

Separate Subscription and Algorithm Functionality #74

Open ebwinters opened 9 months ago

ebwinters commented 9 months ago

The motivation for this PR came after confusion while trying to understand the feed generation process after reading the README. I was looking in the algorithm thinking I missed some logic regarding ALF but was surprised to find it in the subscription

Currently the subscription performs the logic that should reside in the algorithm. Additionally, the current algorithm has nothing to do with text comparison, it just takes latest posts. It could just be called latest-posts.

Indexing posts is independent of generating content, and since whats-alf uses the text of the post, not other metadata, we should store text for this example

ebwinters commented 8 months ago

Anyone gona review this ⁉️

ebwinters commented 8 months ago

@dholms Can I get a review on this PR or someone else who is a maintainer?