search

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
8.21k stars 1.1k forks source link

Bug when I link to a search result within bsky #1384

Open mschwendener opened 1 year ago

mschwendener commented 1 year ago

What is happening here? Chrome and Firefox on Mac

https://bsky.app/profile/manuschwendener.bsky.social/post/3k6nxu63l2o23

When I just click on the link in the post, I get to https://bsky.app/search = the URL gets cut.

When I open the link with right click -> 'Open Link in New Tab', I get to https://bsky.app/search?q=bookshop, which is the URL I pasted.

When I open the link in a new tab with cmd&click, I get to https://bsky.app/search

(Even better would be if the separate tab Users would lead to a separate URL, but that's not urgent).

mschwendener commented 1 year ago

And in iPhone nothing happens when I click on the link.

pfrazee commented 1 year ago

Yeah this is a routing issue

lamrongol commented 7 months ago

I also noticed the same problem and hope to fix because My trend analysis bot needs to show related posts of trend. https://bsky.app/profile/did:plc:7ktx3oe2zbompu3cjwthlest

lamrongol commented 6 months ago

I noticed this problem happens even when 'Open Link in New Tab' on Vivaldi(Chrome) on Windows 11. And, I'm not familiar with English, What does "a routing issue" mean? This issue relates network? not a client?

surfdude29 commented 6 months ago

And, I'm not familiar with English, What does "a routing issue" mean? This issue relates network? not a client?

I think it might mean how links are handled (or routed) internally within the app/website. For example, code like this:

https://github.com/bluesky-social/social-app/blob/main/src/routes.ts

lamrongol commented 6 months ago

I found ad-hoc solution, adding "www" is same link but url doesn't get cut(like following): https://www.bsky.app/search?q=%22Happy+Mar10+Day%22+%7C%7C+Mario+mar

See sample: https://bsky.app/profile/trend-words-en.bsky.social/post/3kndnidi3ge2n

lamrongol commented 2 months ago

Now " https://www.bsky.app/ " is not connected and above hack doesn't work. I can't think of other (adhoc) solutions. Please fix this bug.

surfdude29 commented 2 months ago

This is being tackled in #4574

lamrongol commented 2 months ago

@surfdude29 Thank you and I confirmed "golang / build-and-test (pull_request)" is failed but modified codes are typescript. I can't understand what it mean even I searched. If this check is succeeded, this problem will be solved?

surfdude29 commented 2 months ago

@surfdude29 Thank you and I confirmed "golang / build-and-test (pull_request)" is failed but modified codes are typescript. I can't understand what it mean even I searched. If this check is succeeded, this problem will be solved?

@lamrongol The PR I linked to will hopefully resolve this bug when it is merged, so we just have to be patient while we wait for the team to finish work on that :)