bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
13.19k stars 1.69k forks source link

mention typeahead / autocomplete ditches @sweets.ky #1582

Closed thecubic closed 11 months ago

thecubic commented 1 year ago

Hello hi, my operates-via-mentions bot has a UI problem on desktop web (tested also with mobile, same result exactly)

typing just the @, it shows the target: image

starting to type its name, it disappears immediately: image

even when you type the whole handle, it's invalid: image

This is quite annoying - and actually disabling - I think that I was just lucky enough to mention it as a recent follow to put it in my personal cache, but otherwise it is not possible to mention that handle for other users, which is the point of the bot behind the account

Thanks!

pfrazee commented 1 year ago

Not sure which repo this should be in so I'm putting it on social-app for now.

@ericvolp12 do yall have bandwidth to fold in improvements on this?

ericvolp12 commented 1 year ago

That account doesn't appear to have a app.bsky.actor.profile record at all (no displayname, no bio, etc.) so it didn't get indexed by the search service.

Compare: https://bsky.social/xrpc/com.atproto.repo.listRecords?repo=did:plc:7zmbq3223pb6kx7giq6wuplj&collection=app.bsky.actor.profile

To my repo: https://bsky.social/xrpc/com.atproto.repo.listRecords?repo=did:plc:q6gjnaw2blty4crticxkmujt&collection=app.bsky.actor.profile

Try setting the displayname to something and/or adding a description to the profile, then it should get indexed.

Gonna look into how we can index actors without profile records at least for typeahead with just their handles.

thecubic commented 1 year ago

okay, I've set a profile and it appears now:

image

I just signed up normally (no API touching). The record being absent is a little weird, I'd expect a defaulted record (e.g. display_name="sweetsky.bsky.social")

I'm satisfied and will leave it up to y'all if you want to WONTFIX

ericvolp12 commented 1 year ago

Yeah, I think the PDS should create a profile record even if it just has the displayname=handle when an account is created.

pfrazee commented 11 months ago

Got that tracked in another issue