Quality umbrella

[gaearon]

I'll keep track of some things that are bugging me here.

This is an incomplete list, I'll keep adding stuff here.

• [ ] Shell
  • [x] First load
  • [x] Flicker of white https://github.com/bluesky-social/social-app/pull/1759
  • [x] Feed jumps around sometimes
  • [x] Profile picture in the tab bar disappearing and reappearing during init
  • [x] Glimmer after flicking a feed is missing top margin
  • [x] Top/bottom bar disappearance feels a bit janky
  • [x] https://github.com/bluesky-social/social-app/pull/1683
  • [x] https://github.com/bluesky-social/social-app/pull/1691
  • [x] The content should “push” the bar up, synchronized with the gesture https://github.com/bluesky-social/social-app/pull/1855
  • [x] It's also weird when we're already at the top and just scroll down and up a bit — causes blank space https://github.com/bluesky-social/social-app/pull/1855
  • [x] Switching between feeds while the bar is hidden feels janky due to blank space https://github.com/bluesky-social/social-app/pull/1856
  • [ ] Gesture hell
  • [ ] Swipe between custom feeds with little distance is interpreted as tap on Android
  • [ ] Swipe between custom feeds on the left side is interpreted as a drawer swipe on Android
  • [ ] The feed switching header animation should be synchronized with the swipe gesture
  • [x] Navigating to a profile not via preview (e.g. via link click) is missing a push animation
  • [ ] There is no fade on the background view during back gesture
  • [ ] There is no header crossfade during back gesture
• [ ] Feed
  • [ ] Feed items
  • [x] Layout shift due to galleries https://github.com/bluesky-social/social-app/pull/1673
  • [x] Layout shift when there's a link attachment
  • [x] Tapping a feed item makes the parent post spinner too visible (need to shift it)
  • [x] Tapping a reply may cause a content jump just before it scrolls to reply
  • [x] Button positions in the glimmer are too off
  • [x] Pressing like shouldn't move other buttons
  • [ ] Back gesture feels unreliable when starting with a long press and then a quick swipe; often interprets as tap
  • [ ] There's no tap target feedback e.g. on counts
  • [ ] We're loading too many too large images
    • [ ] Don't upscale images https://github.com/bluesky-social/social-app/issues/1101
    • [ ] Load small avatars by default
    • [ ] Smaller gallery items by default
  • [ ] "In reply to" should be resolved with initial payload
  • [x] Clicking a post in a thread on the web is jumpy
  • [x] Clicking on a post should never show spinner for that post’s content
  • [x] Profile preview
  • [x] Blank background while animating looks broken on Android
  • [x] There is a jump after navigating on iOS due to safe area https://github.com/bluesky-social/social-app/pull/1693
  • [x] There is a flash because the modal disappears before the navigation commits https://github.com/bluesky-social/social-app/pull/1693
  • [x] The initial state is empty but we should have enough info to show the profile shell immediately
  • [x] The display name while loading is misaligned https://github.com/bluesky-social/social-app/pull/1693
  • [ ] Lightbox
  • [ ] Opening lightbox is laggy / misses target on Android (interferes with showing/hiding chrome?)
  • [ ] There's no transition between the thumb and the lightbox image and back
  • [ ] Lightbox doesn't take advantage of the already loaded thumb image (should it?)
  • [ ] Gestures
    • [x] Double tap to zoom
    • [x] https://github.com/bluesky-social/social-app/issues/1275
      • [x] Fix it on Android
      • [x] Align iOS behavior with the Android fix
    • [x] Double tap doesn't work in the header area (even to the left of the close button)
      • [x] Fix: https://github.com/bluesky-social/social-app/pull/1489
    • [x] Pinch
    • [x] https://github.com/bluesky-social/social-app/issues/1485
    • [x] Images in a single post may end up overlapping on Android https://github.com/bluesky-social/social-app/pull/1624
    • [x] Make it resistant to gesture spam https://github.com/bluesky-social/social-app/pull/1666
    • [x] The controls flying away animation is too aggressive https://github.com/bluesky-social/social-app/pull/1687
    • [ ] Swipe
    • [x] Swiping sometimes gets stuck
    • [ ] Hide alt text during swipe?
    • [ ] Black screen feels weird
    • [ ] There's sometimes a spinner behind an already loaded image
  • [ ] Alt text
    • [x] Implement "hide on tap" https://github.com/bluesky-social/social-app/pull/1687
    • [ ] https://github.com/bluesky-social/social-app/issues/1445
• [ ] Notifications
  • [ ] Pressing the notification icon doesn't do the refresh animation properly
  • [ ] Pressing notifications icon second time should clear it
  • [x] Layout is borked when people joined with your invite
• [ ] Profile
  • [x] First profile load jumps https://github.com/bluesky-social/social-app/pull/1690
• [ ] Composer
  • [ ] Cropping needs rethinking on the web

[mozzius]

Pressing the notification icon doesn't do the refresh animation properly

For whatever reason, you can't declaratively show the platform refresh animation - hence the fake spinner. Even if you can't use the platform animation, It'd probably look significantly better if you added Reanimated layout animations so that it didn't jump open/closed

Worth noting twitter shows no animation, and threads shows a spinner in the header, top right - I've yet to find an instance where an app opens the pull-to-refresh thing by pressing a different button.

[gaearon]

Makes sense. Not saying it needs to animate in particular but something feels janky about it. I guess maybe not showing the spinner (like twitter does) may be better.

[mackuba]

@gaearon hey, I finally managed to catch the "jumping up and down when scrolling far down a list" effect that I mentioned recently - I saw this while scrolling on my own profile for posts >1 month ago: https://files.mastodon.social/media_attachments/files/111/371/299/920/026/645/original/29aaba275b20302d.mp4 (starts around ~0:20) Safari 17.1, macOS 12.7.1

I used to see the same thing back in the summer while scrolling the "What's Hot Classic" feed back when it was the "What's Hot" official feed and when it was still possible to scroll a couple of hours back in it.

[gaearon]

Very interesting, thanks!