search

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
8.17k stars 1.08k forks source link

Remove portrait orientation locking from native Android/iOS apps #1872

Open WolfWings opened 10 months ago

WolfWings commented 10 months ago

https://github.com/bluesky-social/social-app/blob/c8c308e31e63607280648e3e9f1f56a371adcd05/app.config.js#L13

Can we get this line either removed, or explicitly changed to 'default' so the native apps stop forcing Portrait orientation please?

https://docs.expo.dev/versions/latest/config/app/#orientation

This appears to have been done blindly as part of moving to "react-navigation" without any consideration for if it was actually needed or not, when it was still using the older app.json format before the file was renamed:

https://github.com/bluesky-social/social-app/blob/56cf890debeb9872f791ccb992a5587f2c05fd9e/app.json#L6

The UI works just fine in Landscape mode if you load it on any number of browsers on mobile (worst case on my 2:1 aspect ratio 2160x1080 6" device is the navigation icons get a scrollbar?), but that results in a sub-par experience due to fighting with browsers built-in gestures on mobile at times.

chrismarquardt commented 10 months ago

+1, landscape rotation, especially for images, is an essential usability requirement

pfrazee commented 9 months ago

We'll try to get this done when we fix up the native tablet behaviors. The web version handles this well because they have different codepaths for some critical layout elements

WolfWings commented 9 months ago

Not unexpected! I lack the technical patience to setup a whole android build environment so I didn't test with the native compile and expected there was likely something I'd missed, but if nothing else the overall progress can be tracked here I figured and all the other various "orientation" things can reference down to this issue hopefully for other folks convenience. :)