bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
8.02k stars 1.04k forks source link

Post text selection accepts multi-touch gestures on mobile #2970

Open MetaflameDragon opened 6 months ago

MetaflameDragon commented 6 months ago

Describe the bug On mobile (or Android, at least), text in posts can be selected even with multi-touch gestures. This causes problems e.g. when a three-finger hold gesture is used to start taking a screenshot.

When I try to take a screenshot and happen to press down in the post (with three fingers), post text is first selected, and then the screenshot gesture triggers.

To Reproduce

Use a multi-touch gesture over any text in a post.

Alternatively, touch in a different spot, then with a second finger on the text.

Expected behavior

Multi-touch gestures are ignored, text is only selected when there is one point of contact.

I believe that text selection should only ever work for the first contact point (first finger), and if a second contact point is ever detected before text selection starts, it should wait until all contact points are released. Alternatively, two contact points in the post text area could select the range - whatever solution feels intuitive and common.

Details

haileyok commented 6 months ago

Is this not the default way that text is selected on Android? I feel (although could be wrong!) that is the normal behavior that I've seen elsewhere but I don't really use Android.