search

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
10.22k stars 1.29k forks source link

Android post composer attempts to autofill passwords #3237

Open Juicysteak117 opened 7 months ago

Juicysteak117 commented 7 months ago

Describe the bug On Android, when composing a post (but not replies, oddly), the phone attempts to autofill any bluesky passwords at the start of text entry.

To Reproduce

Steps to reproduce the behavior:

  1. Have saved passwords
  2. Compose a post
  3. Observe

Expected behavior

Not to autofill my passwords into plaintext fields that I plan to post to thousands of people.

Screenshots

https://github.com/bluesky-social/social-app/assets/20595808/d8d31a12-e01d-4367-8298-2f8db6e652ef

Details

Additional context

haileyok commented 7 months ago

🤯

How often does this happen? I can't repro to save my life but I don't really know about android. Could it be the custom keyboard? Or is it only in weird specific instances?

Juicysteak117 commented 7 months ago

@haileyok Seems to be only on quote skeets upon further testing, but not embedded posts. Very consistent for me. I'm using Fleksy for the keyboard which gives it the password entry prompt like in the video, but even the native Google Keyboard does too (although it doesn't show as a popup, but as a word suggestion in the bar. I don't ever use GK though).

Juicysteak117 commented 7 months ago

Suddenly started happening for any post (not replies though), but after updating to latest Android version, it's back to just quotes. Still consistent.

Juicysteak117 commented 7 months ago

Okay so, some headway. There's definitely something happening that is causing it to start bugging out. Quotes are consistent as always on latest version, but I just had it pop up in replies and on regular posts. On app restart, back to just quotes. I'll try to keep an eye out for when it starts happening since I don't know what behavior it is that is doing it. Seemingly it's not something I do constantly, but at least semi often, and seemingly it causes something to get stuck until restart. The app really does not behave well when left open for a while (see my issue wherever it is about the keyboard breaking), but I'll be very mindful of my usage to see if I can repro.

Juicysteak117 commented 7 months ago

@haileyok More headway. The quote behavior is in any feed when on the home view, but the post and reply behavior (along with quote behavior) happens only when on the profile view. This explains the inconsistency. All of this happens on app launch, so it's not something mid-session changing.