bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
11.95k stars 1.53k forks source link

Several dialogs are only partly localisable #3631

Closed Aonghuso closed 7 months ago

Aonghuso commented 7 months ago

See example screenshots. The words in English are localised in other contexts so that it appears that the strings are not tagged for translation.

f2b69407-b663-42ad-8955-d2a07563c923 e31d9c82-82e3-4e54-b2af-07f3d66f4166 8dfbfc7b-856b-4a2f-b2fc-5998c4bf8654

surfdude29 commented 7 months ago

The strings in the dialogs you posted examples of have actually been marked for translation, as you can see that the prompt shown asking if you want to discard a draft is fully translated in German:

IMG_4007

and the prompt asking if you would like to delete your post is fully translated in Catalan:

IMG_4008

However, it's quite a big job keeping all the translations up-to-date as strings are constantly being added or deleted from the codebase due to bugfixes, new features being added etc, and this effort relies on volunteer contributors.

This chart shows approximately how many missing translations for each locale there currently are:

IMG_4009

As you can see, the translations for some languages are almost complete (Catalan, Italian, Japanese, Korean, Portuguese, Ukrainian and both types of Chinese) while others have more gaps.

If you feel like contributing, translation PRs are always welcome (they just need to be approved by at least one native speaker) 🙂

Aonghuso commented 7 months ago

OK, thanks.

We thought we had translated these strings - or at least something almost identical to GA.

Seeing them untranslated also in other languages led us astray.

We'll try to keep on, so.

Aonghuso commented 7 months ago

I see I don't have the authority to close this, or I'm not doing it properly. But it's resolved from my point of view.

surfdude29 commented 7 months ago

Ah, I hadn't realised you were one of the GA translators, apologies.

We thought we had translated these strings - or at least something almost identical to GA.

In the case of Discard draft that string had indeed been translated for GA. However, when a string is changed even slightly in the app, such as adding a punctuation mark, the previous string and its translation are marked as obsolete in the message catalog (with #~ at the beginning of the line).

So when the the composer code was changed recently and a question mark was added to the Discard draft string, the translation that was done was automatically marked as obsolete in the message catalog and an entry for the new string was added:

https://github.com/bluesky-social/social-app/blob/ce1c1e1cbed05183b42dd44e620fe1d4065bce1e/src/locale/locales/ga/messages.po#L1324-L1330

Translating new strings for features that are added as well as strings that are updated certainly keeps us translators busy! 😅

surfdude29 commented 7 months ago

I see I don't have the authority to close this, or I'm not doing it properly. But it's resolved from my point of view.

You should be able to close the issue by clicking Close issue (it will appear as Close with comment if you have typed in the box.)

IMG_4033 IMG_4034