search

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
7.01k stars 922 forks source link

[🐴] Pill for additional unreads when coming from background #4043

Closed haileyok closed 1 month ago

haileyok commented 1 month ago

Stacked on https://github.com/bluesky-social/social-app/pull/4027

Needs some styling work, but not sure how to make it look right now.

Go to about 2/3 of the way through the video to see effect when foregrounding.

https://github.com/bluesky-social/social-app/assets/153161762/e70500f1-281a-407a-89ac-47214b82c304

render[bot] commented 1 month ago

Your Render PR Server URL is https://social-app-pr-4043.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cp2pccacn0vc73877en0.

github-actions[bot] commented 1 month ago
Old size New size Diff
6.85 MB 6.85 MB 2.22 KB (0.03%)
mozzius commented 1 month ago

Looks super nice, but I'd expect something to happen when you click on it? Not sure if I'd expect it to scroll to bottom or scroll to the oldest unread message though

haileyok commented 1 month ago

Nice, as long as we're okay with the look then we can definitely do that!

haileyok commented 1 month ago

Also I'm torn on the "should it scroll" too. On one hand it would let you get to the bottom quickly, on the other you'd end up missing the new content 🤔

Still think I lean more toward making it scroll down