search

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
8.3k stars 1.11k forks source link

Refresh spinner z-height is too high in some pages, causing it to appear on some pages on back action #4525

Open nokanol45 opened 3 months ago

nokanol45 commented 3 months ago

Describe the bug

When backing out of some pages, e.g. "Feeds", User Lists tab, Liked by and Reposted by pages, a white circle will appear on the page near the center-top for some reason.

To Reproduce

Steps to reproduce the behavior:

  1. Navigate to "Feeds", User Lists tab, Liked by or Reposted by page
  2. Back out of the page with either the top-left arrow or a back gesture/button

Expected behavior

The page backs out normally without the white circle.

Screen recordings

https://github.com/bluesky-social/social-app/assets/101823676/abfc0766-1ab5-42d8-9c47-3f0820c0374f

https://github.com/bluesky-social/social-app/assets/101823676/f3ffba3f-ae4e-4a36-9ba9-8121b9b9642c

https://github.com/bluesky-social/social-app/assets/101823676/9fca68db-0d51-4779-ae3d-5fac0fab8e53

Details

Additional context

AFAIK this issue appeared on the latest app version (1.86.0).

My original thread covering the issue: https://bsky.app/profile/nokanol45.bsky.social/post/3kuqo2ztvpe2j

nokanol45 commented 3 months ago

I figured it out, the white circle is actually the refresh spinner! If you pull down on any of the affected pages, the refresh spinner will inexplicably pop into existence right where the white circle appears! As an example, here's the Feeds page:

https://github.com/bluesky-social/social-app/assets/101823676/894b3c3a-5711-4fa2-a2ac-13d4e6e597b5

So from what I can tell this is an issue with the z-height of the refresh spinner, it can be fixed by placing it behind the header.