search

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
11.94k stars 1.53k forks source link

Screen freezes up when copying QR Code for a Starter Pack #5043

Open j4ckxyz opened 2 months ago

j4ckxyz commented 2 months ago

Describe the bug When you go to any Starter Pack, then click the "Share" button, if you click "Share QR Code" it generates the image just fine, but when you press the "Copy" button, the screen freezes for a few seconds with the cursor being the Link Select cursor (as if you're clicking a link). Can be pretty annoying. I am on an M2 Mac with 8GB of RAM, on Arc browser. image

To Reproduce

Steps to reproduce the behavior:

  1. Go to someone's profile
  2. Click "Starter Packs'
  3. Click the "Share" button
  4. Click "Share QR Code"
  5. Click "Copy"

Expected behavior

Be able to copy the QR code image to the clipboard with little to no delay, or be able to right click the image and "Copy Image" like you can with the Starter Pack images that it puts the profile pictures and name of pack on.

Screenshots

Details

Additional context

nucleartux commented 2 months ago

We can utilize modern-screenshot; it's a little bit faster. I can make a PR.

I think the best solution would be to make a PR to react-native-view-shot, but they might use html2canvas intentionally because it has more features (which we probably don't need) but works a lot slower.