search

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
10.07k stars 1.28k forks source link

Volume control for media player #5285

Closed HybridEidolon closed 1 month ago

HybridEidolon commented 1 month ago

Is your feature request related to a problem? Please describe.

Currently it is possible to mute and unmute videos embedded in posts, but it is not possible to adjust the playback volume.

Describe the solution you'd like

Add a pop-out volume fader as is frequently found on other video player interfaces on the web.

Describe alternatives you've considered

Writing a GreaseMonkey script to add a volume control, but obviously this doesn't work on the native apps.

sighlessm commented 1 month ago

Every video has been blasting me so thanks for opening this.

I would add that it ought to save your selection and apply to ever video thereafter, too. So if I set it at 70% volume for one video, the next video I play is also at 70% volume

netux commented 1 month ago

Something I added on my ticket about this: Please use some sort of logarithmic conversion for the volume slider → video volume, since audio perception isn't linear! Dr. Lex has a great blog post explaining why this is needed, and provides a simple, cheap-ish formula to convert between the two:

video.volume = Math.pow(slider.value /* in the range [0, 1] */, 4);