bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
8.29k stars 1.11k forks source link

Compose box misleads about whether @'s are links when they are prefixed by symbols #5530

Open mcclure opened 2 days ago

mcclure commented 2 days ago

To Reproduce

Open a compose box. Type a word, a /, and an @ name.

image

The name turns blue. It's a mention now, it's not text. Now, remove the space before the @.

image

The text is still blue. Because it is blue, I believe if I click "Post", it will be a link. Click "Post".

image

It's not!! It's just text! An @ preceded by a symbol is not a link. If you had typed "I am testing/@dryad.technology" the compose box would know that. But I tricked it into misleading signaling by typing whitespace before the @ and then removing the whitespace.

Expected behavior

The compose box should detect when the conditions for an @ to be treated as a link on the server side have been violated, and make the text no longer blue (so the user doesn't think they're going to get a link/mention and then fail to get a link/mention)

Details

SpriterGors commented 2 days ago

I had a similar situation not too long ago, but mine was suffixed (placed after the @), as follows:

image Note that the composer makes it look like it is going to generate a clickable link.

image However upon posting the link breaks and it renders as text.

in both cases (prefixed and suffixed), it seems that deleting the space does not toggle off the link color.

I can understand the link being broken, as it makes sense. However it'd make it more obvious if the composer updated the text color from clickable (blue) to non-clickable (white.)

Build version: 1.91.1; Bundle info: 49ab486 (prod); Bundle date: 24092017; Platform: web Platform: Firefox 130.0.1 (64-bits)