search

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
13.19k stars 1.69k forks source link

Vfemail.net isn't a supported email domain #5981

Open Zero3K opened 1 month ago

Zero3K commented 1 month ago

Steps to Reproduce

  1. Go to Settings.
  2. Try to change the email address to one that uses the vfemail,net domain.

Attachments

No response

What platform(s) does this occur on?

iOS, Android, Web (Desktop), Web (Mobile)

Device Info

No response

What version of the app are you using?

1.92.1

Additional Information

No response

surfdude29 commented 1 month ago

What error message are you seeing? I just tried to reproduce this (by entering a nonsense email address ending in @vfemail.net) and I got to the next step fine.

Zero3K commented 1 month ago

This email address is not supported, please use a different email.

surfdude29 commented 1 month ago

This email address is not supported, please use a different email.

Out of interest, do you see that error message as soon as you've typed in your email address and tapped Request Change, or only after you've typed in the confirmation code?

In any case, from what I can tell I think you're right that vfemail.net isn't a supported email domain. (But to be clear, you'll have to email support or wait for one of the team to respond here for an official answer.)

The error message you're seeing comes from here:

https://github.com/bluesky-social/atproto/blob/main/packages/pds/src/api/com/atproto/server/updateEmail.ts#L19

and it looks like the email address is not being validated because it's considered to be 'disposable'. Bluesky seems to use this package to screen out some email domains, and unfortunately vfemail.net seems to be considered disposable by that package as it's on this list (⚠️ warning, large file):

https://raw.githubusercontent.com/disposable/disposable-email-domains/master/domains.txt

So I'm afraid it looks like you'll have to use another email address.

Zero3K commented 1 month ago

VFEmail isn't disposable though since it costs money to have a decent amount of storage and features.

Zero3K commented 1 month ago

I made an issue on that list's repository. It can be found at https://github.com/disposable/disposable/issues/196.

Zero3K commented 3 weeks ago

My pull request to fix it (https://github.com/disposable/disposable/pull/197) has been merged. Now to wait for the domains.txt to be updated (which will no longer have vfemail.net in it once it is updated).

Zero3K commented 3 weeks ago

The domain is removed from that list but Bluesky is still refusing it. I guess Bluesky is using an outdated list.

Zero3K commented 3 weeks ago

What can be done to have it use the latest domains.txt?

Zero3K commented 3 weeks ago

Hmm?

surfdude29 commented 3 weeks ago

What can be done to have it use the latest domains.txt?

I think the issue might be that Bluesky seems to be using the npm package rather than the raw list of domains, and the npm package hasn't been updated for 8 years... 😬

Zero3K commented 3 weeks ago

That needs fixing then.

surfdude29 commented 4 days ago

I just noticed that this has been merged: https://github.com/bluesky-social/atproto/pull/3092 which changes the packages used to validate email addresses. So when that has been rolled out – this is just a guess, but it could be anywhere from a few days to a week, but it could be longer, of course – you might want to try again, as it's possible vfemail.net will be supported 🤞

(Note that I haven't looked into the new packages being used to check, the info is in that PR if you want to check for yourself :)

Zero3K commented 4 days ago

I made a new PR on the repository that has the list that the PR is having Bluesky use. It is at https://github.com/disposable-email-domains/disposable-email-domains/pull/538.

Zero3K commented 2 days ago

How can I know if it has been rolled out?

surfdude29 commented 2 days ago

The only way I know – there may be an easier way of course – is to look at what version the Bluesky PDSes are running here:

https://github.com/mary-ext/atproto-scraping

And then look at that git commit.

But because vfemail.net is in the disposable-email-domains package, I wouldn't get your hopes up 🤷🏻‍♂️

Zero3K commented 2 days ago

The vfemail.net domain should be removed from the list the package uses soon. Just need to wait for the guy who can commit the PR I made to see the screenshots I replied with in the issue I made regarding it.

Zero3K commented 1 day ago

Weird, the change has been rolled out and the PR I made has been merged but the domain is still being blocked.

Zero3K commented 1 day ago

I think it is because it is using an outdated blocklist. So, it is going to have to be updated when a new version of that package is available. I told the guy who develops it to update its blocklist and also made an issue for getting it to always using the latest one.

Zero3K commented 8 hours ago

I made a PR to update the package version used since it was updated to use the latest .conf file. It can be found at https://github.com/bluesky-social/atproto/pull/3138. Merging it should get this issue to be fixed after the scraper shows that it has been updated.