search

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
10.14k stars 1.29k forks source link

Vfemail.net isn't a supported email domain #5981

Open Zero3K opened 1 week ago

Zero3K commented 1 week ago

Steps to Reproduce

  1. Go to Settings.
  2. Try to change the email address to one that uses the vfemail,net domain.

Attachments

No response

What platform(s) does this occur on?

iOS, Android, Web (Desktop), Web (Mobile)

Device Info

No response

What version of the app are you using?

1.92.1

Additional Information

No response

surfdude29 commented 1 week ago

What error message are you seeing? I just tried to reproduce this (by entering a nonsense email address ending in @vfemail.net) and I got to the next step fine.

Zero3K commented 1 week ago

This email address is not supported, please use a different email.

surfdude29 commented 1 week ago

This email address is not supported, please use a different email.

Out of interest, do you see that error message as soon as you've typed in your email address and tapped Request Change, or only after you've typed in the confirmation code?

In any case, from what I can tell I think you're right that vfemail.net isn't a supported email domain. (But to be clear, you'll have to email support or wait for one of the team to respond here for an official answer.)

The error message you're seeing comes from here:

https://github.com/bluesky-social/atproto/blob/main/packages/pds/src/api/com/atproto/server/updateEmail.ts#L19

and it looks like the email address is not being validated because it's considered to be 'disposable'. Bluesky seems to use this package to screen out some email domains, and unfortunately vfemail.net seems to be considered disposable by that package as it's on this list (⚠️ warning, large file):

https://raw.githubusercontent.com/disposable/disposable-email-domains/master/domains.txt

So I'm afraid it looks like you'll have to use another email address.

Zero3K commented 1 week ago

VFEmail isn't disposable though since it costs money to have a decent amount of storage and features.

Zero3K commented 1 week ago

I made an issue on that list's repository. It can be found at https://github.com/disposable/disposable/issues/196.

Zero3K commented 3 days ago

My pull request to fix it (https://github.com/disposable/disposable/pull/197) has been merged. Now to wait for the domains.txt to be updated (which will no longer have vfemail.net in it once it is updated).

Zero3K commented 2 days ago

The domain is removed from that list but Bluesky is still refusing it. I guess Bluesky is using an outdated list.

Zero3K commented 2 days ago

What can be done to have it use the latest domains.txt?