Remove unused 'react-scripts' devDependency

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android

https://bsky.app

MIT License

11.85k stars 1.52k forks source link

Remove unused 'react-scripts' devDependency #6441

Closed trivikr closed 5 days ago

trivikr commented 5 days ago

Fixes: https://github.com/bluesky-social/social-app/issues/6440

gaearon commented 5 days ago

nice catch

trivikr commented 5 days ago

This removal broke web target since social-app was using file-loader from transitive dependency of unused react-scripts and didn't have a direct dependency on:

Bug report https://github.com/bluesky-social/social-app/issues/6462
Fix in https://github.com/bluesky-social/social-app/pull/6459

gaearon commented 5 days ago

Actually this also seems to have broken native builds too. I should have reviewed instead of trusting the CI.

gaearon commented 5 days ago

Nvm, clearing the caches fixed that.