search

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
12.74k stars 1.62k forks source link

Fix build #6459

Closed gaearon closed 1 week ago

gaearon commented 1 week ago

https://github.com/bluesky-social/social-app/pull/6441 removed file-loader but we implicitly use it in the webpack config. Add it to dependencies so it doesn't get lost.

Test Plan

yarn web works again

trivikr commented 1 week ago

Fixes https://github.com/bluesky-social/social-app/issues/6462

trivikr commented 1 week ago

Change PR title to Add direct dependency to "file-loader" used in webpack config or similar?

trivikr commented 1 week ago

The expo export:web is failing as per CI.

ModuleNotFoundError: Module not found: Error: Can't resolve 'file-loader' in '/home/runner/work/social-app/social-app'
ModuleNotFoundError: Module not found: Error: Can't resolve 'file-loader' in '/home/runner/work/social-app/social-app'

https://github.com/bluesky-social/social-app/actions/runs/11880663670/job/33104085536?pr=6459

I'm not sure why it's trying to find file-loader in non-existent social-app folder in the repo.