bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
11.24k stars 1.43k forks source link

Remove usused direct dependencies on `webpack` #6461

Open trivikr opened 3 hours ago

trivikr commented 3 hours ago

Describe the Feature

The direct dependencies for webpack were added on migrating from "react-scripts" in https://github.com/bluesky-social/social-app/commit/d6ec627c8cd32836e5ed494606318959ca17fca1. However, they weren't removed when we target moved to expo in https://github.com/bluesky-social/social-app/pull/288

The following dependencies can be removed as they're imported elsewhere:

Following dependencies can be removed as they're no longer used:

Attachments

No response

Describe Alternatives

No response

Additional Context

No response

gaearon commented 3 hours ago

If you remove them, please do verify that the build actually works — see https://github.com/bluesky-social/social-app/pull/6459 for context.

trivikr commented 3 hours ago

Thanks for providing a fix!

I just created a bug report when testing removal of webpack dependencies at https://github.com/bluesky-social/social-app/issues/6462

trivikr commented 2 hours ago

please do verify that the build actually works

ToDo: Run yarn web and verify whenever this task is taken up. Instructions: https://github.com/bluesky-social/social-app/blob/main/docs/build.md#running-web-app