search

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
11.82k stars 1.51k forks source link

Migrate from yarn classic to yarn berry. #6490

Closed PaulACoroneos closed 3 days ago

PaulACoroneos commented 4 days ago

Closes #6478

References:

yarn classic to berry migration guide why yarn berry over classic

PaulACoroneos commented 4 days ago

I at least ran "web" locally and clicked around localhost and things seems fine. Unfortunately I am not having as much luck with native right now (getting errors I don't quite understand). I will have to try to figure that out in next several days but it was before this change so its likely unrelated since its failure is not during yarn install

PaulACoroneos commented 4 days ago

The only other concern is whether the GitHub actions properly will use the new .yarnrc.yml ( I know when I did a gitlab migration in past I had to change some things). I guess I will know more once build completes.

gaearon commented 3 days ago

Are there any other big projects that migrated and are happy with the experience? I never used Berry before

PaulACoroneos commented 3 days ago

Are there any other big projects that migrated and are happy with the experience? I never used Berry before

I can't speak for other OSS as I am fairly new to contributing but for the repo I implemented it came with some nice benefits. The biggest of course would by yarn PnP mode but that's significantly more complex. I found the investment was better spent eventually moving to pnpm. But this is a nice intermediate step since yarn classic gets no additional support currently from the yarn team. Builds and installs do get a decent bump even in node-linker mode.

Since I have you here I think my blocker is the patch-package versions of several deps. I am not exactly sure what the process is expected here around that. It appears in one case the dependency may not even be used anymore. Is there documentation on how this should be handled? Otherwise I can try to stake a stab at manually updating the latest patch version of the packages then running patch package again.

Thank you for your time.

gaearon commented 3 days ago

yeah tbh i don't think we can prioritize big infra changes like this at the moment, and i think we might as well adopt pnpm if we're making a change like this

PaulACoroneos commented 3 days ago

yeah tbh i don't think we can prioritize big infra changes like this at the moment, and i think we might as well adopt pnpm if we're making a change like this

okay that's reasonable. ill go ahead and close as won't do against considering pnpm. I don't think its easy for you to forecast when such an update will have bandwidth from team so may I can ask sometime later in 2025. take care.