bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
12.64k stars 1.61k forks source link

useAnimatedReaction in imageitem.android.tsx and imageitem.ios.tsx have logic bug #6499

Closed PaulACoroneos closed 3 days ago

PaulACoroneos commented 1 week ago

Steps to Reproduce

While I was working on Eslint v9 upgrades one of the rules exposed the following logic bug in both imageitem.android.tsx and imageitem.ios.tsx

code snippet with unreachable code

I'm struggling to understand how we would ever reach the else if since the logic condition is the same. If I understand right this was introduced with #6159. I would propose I just remove the else if but I need confirmation from @gaearon whether I have not missed something here.

Attachments

No response

What platform(s) does this occur on?

iOS

Device Info

No response

What version of the app are you using?

n/a

Additional Information

No response

gaearon commented 1 week ago

Yea that looks like a bug.