bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
11.8k stars 1.51k forks source link

Add eslint recommend and typescript recommended to eslint config #6557

Open PaulACoroneos opened 2 days ago

PaulACoroneos commented 2 days ago

Describe the Feature

It's highly recommended we add eslint recommended and typescript eslint recommended to the eslint config to help us catch common mistakes.

https://typescript-eslint.io/getting-started/legacy-eslint-setup (this is for our current v8 setup, when we go to v9 and eslint.config.mjs it will refactor into something slightly different)

Since this app uses typescript, recommendedTypedCheck is a better fit but comes with some downsides.

To do a brief check I went ahead and created a branch which implements this (have not raised PR yet). Several rules should be turned off initially as to not create a massive PR. Rules can then be "enabled" with follow-up PR. The benefit is there as I confirmed a bug I reported last week was caught by the recommended ruleset.

If an early look is wanted, the branch is pushed to origin and diff may be viewed here. I am waiting for the prettier rule removal PR to be approved so I can rebase first.

This will help us continue our journey toward Eslint v9. Thank you so much for your help/patience so far.

Attachments

No response

Describe Alternatives

No response

Additional Context

No response