search

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
11.76k stars 1.5k forks source link

Add `CFBundleLocalizations` key to `Info.plist` #6567

Open surfdude29 opened 1 day ago

surfdude29 commented 1 day ago

Even though Bluesky has been localized into more than 20 languages, the App Store listing still shows it as only available in English:

IMG_1163

After some research, it appears that including the list of supported languages in a CFBundleLocalizations key in the Info.plist file might enable all the supported languages to be displayed in the App Store listing. (source 1, source 2, source 3)

This will also hopefully fix #6162 and enable the TextInput context menus to be localized on iOS (they currently always display in English).

andreazllin commented 1 day ago

Are all those values valid? Taking a look at CFBundleLocalizations docs, seems like Apple only marked some as possibile values, not sure if it's an oversight on their side or not.

surfdude29 commented 1 day ago

Yes I thought that was rather confusing, but I'm pretty sure those are just examples of language codes, rather than all possible values. It would be really weird not to allow developers to localize their apps in Spanish, for instance, which isn't listed.

andreazllin commented 1 day ago

Yeah that makes sense! 👍🏻

Apple should've specified the standard they're using for that property or specify the entire list for it