search

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
11.76k stars 1.5k forks source link

Improve error name and message for signed-in only feeds #6577

Open estrattonbailey opened 1 day ago

estrattonbailey commented 1 day ago

When viewing a feed as a signed-out visitor to our web app, we check pages of posts to see if any posts pass the default signed-out moderation settings. If none pass, we show an error screen in place of an entirely empty feed. We do this to prevent endless frontend fetching, trying to find a full page (30) posts that pass moderation and can be shown to the public.

Important to note: no-unauthenticated labels on users are also caught by this moderation check, meaning if a feed is full of folks who have opted out of public views, we will also show this error screen on the feed.

The previous error name and copy was a little misleading, and maybe concerning to some users. This PR aims to make it a little more clear what's happening. In the future we should revisit how we handle this "error" state.

CleanShot 2024-11-20 at 13 50 44@2x

github-actions[bot] commented 1 day ago
Old size New size Diff
8.06 MB 8.06 MB 21 B (0.00%)