Fix Fast Refresh in <Text> files

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android

https://bsky.app

MIT License

11.77k stars 1.5k forks source link

Fix Fast Refresh in <Text> files #6609

Closed gaearon closed 6 hours ago

gaearon commented 7 hours ago

It was very annoying to iterate on the Text components because the app always reloaded. This was because those files export non-React functions, and so the edit was propagating up the module system and wasn't fully handled. The fix is to move non-React stuff to another file.

There are no logic changes.

Test Plan

Save file in Text.tsx or Typography.tsx, the entire app no longer reloads.

github-actions[bot] commented 7 hours ago

Old size	New size	Diff
8.06 MB	8.06 MB	547 B (0.01%)