bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android

https://bsky.app

MIT License

11.76k stars 1.5k forks source link

Fix overflow issue on iOS autocomplete, among other things #6611

Closed mozzius closed 3 hours ago

mozzius commented 5 hours ago

Fixes a few issues with the autocomplete

Fixes overflow issue on iOS (ripped out a dumb system based on number of characters and just figured out how to do the same behaviour with flexbox)
Fixes missing display name issue on web (search for @zed.dev to see this)
Remove use of reading refs in render in favour of the built-in flag on the hook
Use unicode symbol for ellipsis instead of ... (since this looks weird next to numberOfLines)

Before	After

Test plan

Check that the overflow issue is indeed fixed (iOS) and check that I didn't break anything (Android)
Check that it still maintains stale items as you type (this is what the ref did)
Check that accounts where the displayname is >50% width and handles are short still take up as much space as they can (iOS + Android) - @atproto.com is a good example

github-actions[bot] commented 5 hours ago

Old size	New size	Diff
8.06 MB	8.06 MB	-1 B (-0.00%)