search

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
11.82k stars 1.51k forks source link

[Android] Lower Feed maxRenderPerBatch #6624

Closed gaearon closed 10 hours ago

gaearon commented 10 hours ago

These batches can drop frames really hard since each row is a feed story (which may have embeds etc).

Let's just be conservative on Android and try to unblock as much as possible. I'm not seeing a lot of blank spaces in practice unless I scroll super hard. Whereas the frame-by-frame improvement is quite noticeable, especially on embed-heavy feeds like the News feed. And I assume on higher end it'll work even better.

Test Plan

Scroll up and down different feeds.

Also try "scroll to top" and scrolling down after to try to trigger blanks.

Before

This was captured with the News feed (which has embeds and is consistently ordered). Five scrolls down with momentum.

Screenshot 2024-11-22 at 04 16 22

After

Same, five scrolls on News feed.

Screenshot 2024-11-22 at 04 13 55

And it just feels better, you know.

github-actions[bot] commented 10 hours ago
Old size New size Diff
8.06 MB 8.06 MB 5 B (0.00%)