bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
8.32k stars 1.11k forks source link

web: body should not exceed viewport height, and scroll action should always be captured by middle column #729

Closed llllvvuu closed 1 year ago

llllvvuu commented 1 year ago

Describe the bug

To Reproduce

Steps to reproduce the behavior:

  1. Make your browser height really small
  2. Scroll to the bottom of the feed and then scroll further, OR scroll while hovered over side bars (if browser is not small, this just blocks, which is also not ideal)

Expected behavior

Should be able to scroll poasts with mouse anywhere. Should not go offscreen.

Screenshots

Screenshot 2023-05-17 at 9 58 13 PM

Details

Additional context

If we agree on the expected behavior, I would be happy to provide a fix.

pfrazee commented 1 year ago

agree this is an issue, accepting a fix depends on how the fix is implemented

llllvvuu commented 1 year ago

Unfortunately I was only able to fix the first part of this (overflowing): #762

The scroll capture part is trickier because the <ScrollView>/<CenteredView> is a sibling of the <LeftNav> and scrolling only bubbles up to the parent.

The reason it works on Twitter Desktop is that they put the super long <main> container directly under the parent, so that the parent can just overflow: scroll. But we can't do that, because React Native ScrollView is a fixed-height wrapper.