search

bluesky-social / social-app

The Bluesky Social application for Web, iOS, and Android
https://bsky.app
MIT License
7.23k stars 952 forks source link

Replying to older threads should render that reply in the timeline #746

Open bdimcheff opened 1 year ago

bdimcheff commented 1 year ago

Describe the bug

If you reply to one of your old posts it doesn't show up in anyone's home timelines.

To Reproduce

Steps to reproduce the behavior:

  1. Go to your own profile, find a post from yesterday or something.
  2. Reply to that old post, creating (or continuing) a thread.
  3. Go to your home timeline. You won't see that reply. Nobody else will either.

Expected behavior

Show the reply to your thread, preferably with some context that it is a thread (potentially the last 1 or more posts). Twitter works this way.

twitter:

Screenshot 2023-05-18 at 21 49 42

this is what it could look like, where (part of) the thread is inserted where the most recent post is, chronologically. In main, it's missing all the replies from my test account and just has my two posts from my main account.

Screenshot 2023-05-18 at 21 53 20

Screenshots

Details

Additional context

I'm going to open a PR in a sec that explains what I think is happening. It doesn't actually fix it fully, because I can't quite get there.

teancom commented 11 months ago

I have a long running thread listing out all of the books I've read this year, and my "work around" to this bug is to self-boost every reply as I make it, which only helps for those folks who don't have boosts disabled. Which, as someone who has boosts disabled, I completely understand why you would do that. But the alternative would be to quote skeet myself every time which... ick. Ick! So between this bug and the lack of being able to disable boosts per account followed vs. globally, I know there are people who are following me who have no idea about my book review thread.

bdimcheff commented 11 months ago

@teancom yeah this is close to what I'm trying to do (except with pictures of cats that i've pet)

mary-ext commented 4 months ago

Don't know how I missed this one issue when I filed the PR but this PR adds bumping to replies https://github.com/bluesky-social/social-app/pull/2604

It's in 1.68 already for all platforms

Can you check if this addresses the issue presented here, or is there something more that it hasn't yet addressed?