bluesky / bluesky-adaptive

Reference implementation for tightly integrated adaptive scans.
https://blueskyproject.io/bluesky-adaptive
BSD 3-Clause "New" or "Revised" License
4 stars 10 forks source link

Enable pre-commit and install extras #32

Closed padraic-shafer closed 8 months ago

padraic-shafer commented 8 months ago

Enabled installation of any "extras", including "dev" requirements. Re-enabled pre-commit by updating pinned dependencies.

Description

Motivation and Context

Summary of Changes for Release Notes

Enabled installation of any "extras", including "dev" requirements. Re-enabled pre-commit by updating pinned dependencies.

Fixed

Changed

How Has This Been Tested?

Tested locally on MacOS M2

python -m pip install -e '.[all]'
python -m pip install -e '.[dev, agents]'  # redundant, but no errors

pre-commit run --all-files
maffettone commented 8 months ago

Like it! This does a good job sorting some end-of-file fixes and trailing whitespace issues that snuck in from a lack of pre-commit function.

These should also be added to the GHA to mirror pre-commit.

Otherwise, this is good to go after fixing some lint.

padraic-shafer commented 8 months ago

Otherwise, this is good to go after fixing some lint.

Thanks, I missed that earlier. It should be ready for approve/merge now.