search

bluesky / bluesky-kafka

Kafka integration for bluesky
Other
5 stars 10 forks source link

De-dent unchecked assertions in pytest.raises blocks #54

Closed jklynch closed 1 year ago

jklynch commented 1 year ago

This PR fixes several cases in the tests in which assertions were made inside pytest.raises blocks but were never checked. This is because the assertions were made at a point in the test that was not executed due to the expected exception being raised. De-denting the assertions to be outside the pytest.raises block solved the problem.

Thanks to @mrakitin for finding these errors!

jklynch commented 1 year ago

I agree, no need to release this yet.