search

bluesky / bluesky-queueserver

Server for queueing plans
https://blueskyproject.io/bluesky-queueserver/
BSD 3-Clause "New" or "Revised" License
11 stars 20 forks source link

Shift from aioredis to redis #276

Closed clintonroy closed 1 year ago

clintonroy commented 1 year ago

Aioredis is now, more or less, merged into redis. As aioredis is now archived, better to shift to redis directly.

Description

Modify imports to use redis. Remove code that handles older versions of aioredis.

Motivation and Context

Attempting to shift to python3.11 showed up a couple of issues with aioredis, and that led me down the path of discovering that it's now archived.

Summary of Changes for Release Notes

Fixed

Added

Changed

Removed

How Has This Been Tested?

We've tested this, in a limited way, on AS beamlines. We can start the queueserver, add and run plans.

I could not run the tests by following the contributing guide, hoping the CI does that.

tacaswell commented 1 year ago

This seems reasonable to me. The failure looks transient (given that it only happens in 1 test case....), tried restarting.

dmgav commented 1 year ago

Looks good to me. Unfortunately the tests are complicated and there are a lot of them, so failures on CI are quite common.

@clintonroy What issues did you have with running the tests locally?