bluesky / bluesky-widgets

Components for graphical applications that interact with bluesky libraries
http://blueskyproject.io/bluesky-widgets
BSD 3-Clause "New" or "Revised" License
7 stars 23 forks source link

Enable 'pause' buttons whenever Run Engine is in 'running' state. #187

Closed dmgav closed 1 year ago

dmgav commented 1 year ago

Small change in the behavior of RE Manager control widgets: 'Pause Deferred' and 'Pause Immediate' buttons are now activated whenever the Run Engine is in 'running' state. The buttons can be used to pause a running plan, started in the worker directly using Jupyter Console (worker in IPython kernel mode), bypassing the manager.

The buttons are also activated when the manager is switched to the 'executing_queue' mode, which happens immediated after the queue is started by the manager. This makes GUI look more responsive.

The PR also contains some maintenance changes:

How Has This Been Tested?

The feature was manually tested.

tacaswell commented 1 year ago

failure is during installation of doc environment.

dmgav commented 1 year ago

@tacaswell But I don't see the unit tests GH action to be running at all. It could be the same issue though.

tacaswell commented 1 year ago

oh, I completely missed the tests did not run (saw green check marks but did not read what they where)

tacaswell commented 1 year ago

There was a cron job on the tests and we made no changes to the repo for long enough the Europe got disabled.

I turned it back on