bluesky / event-model

data model for event-based data collection and analysis
https://blueskyproject.io/event-model
BSD 3-Clause "New" or "Revised" License
13 stars 30 forks source link

Add convenience methods to DocumentRouter #165

Closed jklynch closed 4 years ago

jklynch commented 4 years ago

I propose some convenience methods for DocumentRouter along these lines:

I find myself reimplementing this functionality virtually every time I subclass DocumentRouter.

tacaswell commented 4 years ago

I'm sold on the first two if we already keep enough state to answer that question, a bit skeptical but still net positive if we have to add the state tracking.

The third seems likes self.descriptor_for_event(event_doc)['name'] so neutral on it.

jklynch commented 4 years ago

addressed by #166