search

bluesky / event-model

data model for event-based data collection and analysis
https://blueskyproject.io/event-model
BSD 3-Clause "New" or "Revised" License
13 stars 30 forks source link

Unpin jsonschema in requirements? #193

Closed dylanmcreynolds closed 3 years ago

dylanmcreynolds commented 3 years ago

The travis configuration effectively pins it to jsonschema 2.x because of an issue with PIP sometimes pulling down 2 instead of 3.

I raised this an issue in slack, and @tacaswell said "we should probably un-pin the jsonschema version".

danielballan commented 3 years ago

I thought he was suggesting un-pinning it in our requirements. I think we need to keep pinning it in Travis to ensure that it keeps working on 2 and 3.

dylanmcreynolds commented 3 years ago

that's a little confusing, in requirements.txt:

jsonschema>=3.0.0

danielballan commented 3 years ago

Right. Since pip sometimes does not respect pins (long story) we sometimes get 2.x in spite of that pin. For this reason, we restored compact with both 2 and 3 and continue to test on both. Given that, there is no reason to continue to pin in the requirements file.