bluesky / event-model

data model for event-based data collection and analysis
https://blueskyproject.io/event-model
BSD 3-Clause "New" or "Revised" License
13 stars 30 forks source link

Remove start restrictions #237

Open cjtitus opened 1 year ago

cjtitus commented 1 year ago

Removes restrictions on certain keys in the start document, addressing #225

Description

Removes restrictions on the following keys in the start document:

project
sample
group
owner

Motivation and Context

As discussed in #225 there is little present justification for restricting project, sample, group, or owner, which are not used in any systematic way, and are not planned to be used in a central way that requires validation. group and owner in particular are probably holdovers from old notions of how to do unix-permission-based authentication, which is not used in any way. Things like project and sample could conceptually be integers, or dictionaries, and should not be limited in their present fashion.

How Has This Been Tested?

I tested locally that removing the restrictions does, in fact, allow you to create a start document with the given keys taking arbitrary values. However, it probably doesn't make sense to add any tests to the test suite.