Closed evalott100 closed 1 year ago
Suggest it would be a good time to make a bluesky version of python3-pip-skeleton. The steps:
@danielballan Pretty much good to go I think, let me know the answers to Tom's questions in the unresolved conversations and I'll make changes :slightly_smiling_face:
Had to close since we'll use a new branch with the bluesky skeleton adoption.
@coretl asked some questions related to this PR via DM. I'll consolidate them here:
do we still need to test against different jsonschema versions?
Yes, as long as it's not too much trouble. Pip dependency resolution frequently gave us an older version that created troubles, not that long ago.
do you use numpy style everywhere?
Yes, that is the standard throughout Bluesky projects.
did I get the RST title underline style right?
Yep!
Closes #240
Converts event-model to use the DLS python skeleton, adding all the features other than the
.vscode
and the container, the following have been added:pyproject.toml
instead ofrequirements.txt
andrequirements-dev.txt
setup.py
instead of versioneerThe CI has been tested, and will fail only on flake8 and mypy since the master branch
__init__
.py does not yet have typing support.This change will introduce to event-model the older commits to the DLS python skeleton - those which altered features which will be included in this PR.