Closed evalott100 closed 1 year ago
For 1) I think that as soon as we compose a descriptor then we should mention the number of events in the stop document, so {'primary': 0, 'baseline': 2}
would be reasonable for me.
For 2) I don't understand how a bundle_name
of None
is added, and why if would be excluded from the stop document.
@danielballan @tacaswell any ideas?
For 2), assert when populating sequence_counters that bundle_name is not None
First problem
In the below snippet of code , the descriptor name is added to the event_list as a key, with number of events of 1, even if the descriptor hasn't had any code inserted.
This causes a
num_events
to be inaccurate causing the following behaviour:instead of what is depicted in the following assertion, as well as
in this assertion.
Do we keep the current bluesky behaviour by filtering out descriptors with an event_counter of 1, or do we add in the descriptor name with
num_events
of 0 directly? @danielballan @coretlSecond problem
The following code in the bluesky bundler isn't accounted for in event_model, it can be added very easily on
compose_stop
, let me know what you think.