search

bluesky / event-model

data model for event-based data collection and analysis
https://blueskyproject.io/event-model
BSD 3-Clause "New" or "Revised" License
13 stars 29 forks source link

Rethinking external assets 2 #272

Closed evalott100 closed 9 months ago

evalott100 commented 1 year ago

Closes #236

Putting on a new branch for cleanliness

danielballan commented 9 months ago

I'm on board with retroactively applying black, but it would be best to do that in its own PR so that this PR is more reviewable as a unit.

evalott100 commented 9 months ago

I'm on board with retroactively applying black, but it would be best to do that in its own PR so that this PR is more reviewable as a unit.

I was a little confused because the CI was checking against black. I think this relates to a local problem of line length being max 79 characters now (I think maybe flake8 changed the default line length, or the max-line-length option).

I'll revert the commit and see what's happening.

danielballan commented 9 months ago

Oh, odd. I know we've retroactively applied black to some-but-not-all legacy bluesky repos. I can't remember for sure whether we did it here, but the single quotes in the codebase suggest we haven't.

evalott100 commented 9 months ago

@danielballan

Found it!

https://github.com/bluesky/event-model/commit/01898f228dc365ceb766785120c707a9897eee36

I'm unsure why these things are changing now though... Maybe a new black release, I think I see some highlights in the recent black releases which match up (I used 23.9.1 locally) :thinking:

I'll run black on a different branch off of main and make a new PR.

Edit

Never mind, origin is already black compliant. This branch seems to have a very minor black change so I'll leave it here. Something must have been wrong locally in the last commit.

danielballan commented 9 months ago

Ah, OK, that makes sense. I think we are good to merge then.