search

bluesky / hklpy

Diffractometer computation library with ophyd pseudopositioner support
https://blueskyproject.io/hklpy
BSD 3-Clause "New" or "Revised" License
4 stars 12 forks source link

Increase precision of A_KEV constant #206

Closed prjemian closed 3 years ago

prjemian commented 3 years ago

FIX #172, to match 2018 CODATA value.

prjemian commented 3 years ago

@mrakitin Ready for review. I'm thinking of a 1.0.1 release next week. Maintenance (and maybe bug fix). Only a few changes.

prjemian commented 3 years ago

Separator for the last column does not have too fill the full width. This is a restructured text rule.

On Thu, Sep 16, 2021, 1:06 PM Maksim Rakitin @.***> wrote:

@.**** approved this pull request.

Looks good to me. I think the sphinx separator may need to be updated (suggested below).

In RELEASE_NOTES.rst https://github.com/bluesky/hklpy/pull/206#discussion_r710355925:

+v1.0.1 (2021-09-20 or thereabouts)

+======================

⬇️ Suggested change

-v1.0.1 (2021-09-20 or thereabouts)

-======================

+v1.0.1 (2021-09-20 or thereabouts)

+==================================

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/bluesky/hklpy/pull/206#pullrequestreview-756618123, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARMUMCZGW3WMUNRRQC6EJ3UCIW2TANCNFSM5EDDJ57Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mrakitin commented 3 years ago

Separator for the last column does not have too fill the full width. This is a restructured text rule.

Can it be shorter or longer? I remember we had to match the length of the heading with the length of the separators (see e.g. https://github.com/NSLS-II/scientific-python-cookiecutter/pull/78).

prjemian commented 3 years ago

The last column is different than the others. It can be a different length than the widest content row. Not sure what is there minimum, guessing it might be at least 3.

On Thu, Sep 16, 2021, 1:22 PM Maksim Rakitin @.***> wrote:

Separator for the last column does not have too fill the full width. This is a restructured text rule.

Can it be shorter or longer? I remember we had to match the length of the heading with the length of the separators (see e.g. NSLS-II/scientific-python-cookiecutter#78 https://github.com/NSLS-II/scientific-python-cookiecutter/pull/78).

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/bluesky/hklpy/pull/206#issuecomment-921139165, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARMUMFO763RTISDINV275LUCIYVXANCNFSM5EDDJ57Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

prjemian commented 3 years ago

For example:

The rightmost column is unbounded; text may continue past the edge of the table (as indicated by the table borders). However, it is recommended that borders be made long enough to contain the entire text.

prjemian commented 3 years ago

From this, I understand the width of the rightmost === border can be shorter than or equal to the width of the widest content row.

prjemian commented 3 years ago

Hold it, though, that's for tables, this is a section heading, it must be equal to (or greater than) the content width of the row above it. I'll take your suggestion. Ack!

prjemian commented 3 years ago

That's the consequence of reading on a mobile phone.