bluesky / hklpy

Diffractometer computation library with ophyd pseudopositioner support
https://blueskyproject.io/hklpy
BSD 3-Clause "New" or "Revised" License
4 stars 12 forks source link

update versioneer #235

Closed prjemian closed 2 years ago

prjemian commented 2 years ago

Confirm if updates to versioneer support is necessary. (Note similar PR https://github.com/bluesky/hkl-notebooks/pull/4) with these remarks:

SafeConfigParser has been deprecated since Python 3.2 and will be removed in py312.

https://github.com/python/cpython/pull/28292 https://bugs.python.org/issue45173 https://github.com/python/cpython/issues/89336

Similar code exists now in hklpy: https://github.com/bluesky/hklpy/blob/208652f1c93a343f1fef85098b96d9ec90d6962d/versioneer.py#L403

prjemian commented 2 years ago

See: Updating Versioneer

prjemian commented 2 years ago
(dev-hklpy) prjemian@zap:~/.../Bluesky/hklpy$ versioneer install 
replacing old versioneer.py (0.15)
versioneer.py (0.22) installed into local tree
Now running 'versioneer.py setup' to install the generated files..
 creating hkl/_version.py
 appending to hkl/__init__.py
 'versioneer.py' already in MANIFEST.in
 versionfile_source already in MANIFEST.in
prjemian commented 2 years ago

These changes include the principle change implemented in PR https://github.com/bluesky/hkl-notebooks/pull/4:

    parser = configparser.ConfigParser()

This additional change remains to replace the two lines following:

    parser.read(setup_cfg)