BUG: add_reflections() crashes session when ...

bluesky / hklpy

Diffractometer computation library with ophyd pseudopositioner support

https://blueskyproject.io/hklpy

BSD 3-Clause "New" or "Revised" License

2 stars 11 forks source link

BUG: add_reflections() crashes session when ... #307

Closed prjemian closed 6 months ago

prjemian commented 7 months ago

@jwkim-anl reports that sample.HklSample.add_reflections() method crashes a session under certain conditions:

wrong number of real axis positions are provided
pseudo axes were not provided, just the angles

prjemian commented 7 months ago

The crash comes from the lower-level libhkl code, since it was called incorrectly. The Python code should be more robust. The inputs to the method should be validated before calling the libhkl code:

correct number of arguments (len(pseudos) + 1)
last argument is either a list, tuple, or namedtuple with len(arg[-1]) = len(real_axes)
all arguments should evaluate to numbers (int or float)

Python data typing might assist some of these validations.

Thanks, @jwkim-anl, for the bug report.