avoid crash in add_reflections, add axes_(r,w,c)

bluesky / hklpy

Diffractometer computation library with ophyd pseudopositioner support

https://blueskyproject.io/hklpy

BSD 3-Clause "New" or "Revised" License

4 stars 12 forks source link

avoid crash in add_reflections, add axes_(r,w,c) #309

Closed prjemian closed 9 months ago

prjemian commented 10 months ago

close #307
close #308

@jwkim-anl : Thanks for the bug report!

prjemian commented 9 months ago

@padraic-shafer : I hardened the validation process for namedtuples. Previously, an unacceptable namedtuple instance was handled by isinstance(pos, (list, tuple)).

padraic-shafer commented 9 months ago

Although probably beyond what you have in mind for this PR, the extent and combination of validation tests suggest that hypothesis for property-based testing could be worthwhile in the long run.

prjemian commented 9 months ago

That looks like a good addition for the v2.0 release. For now, I'm trying to keep this v1.1.0 release limited to the new geometries and some user-requested features & bug fixes. This is the last planned minor (semver: major.minor.patch) release before v2. Since the changes for v2.0 are planned as a complete overhaul, this might be too much for now.

prjemian commented 9 months ago

@padraic-shafer @mrakitin : Thanks for the reviews!