search

bluesky / ophyd-async

Hardware abstraction for bluesky written using asyncio
https://blueskyproject.io/ophyd-async
BSD 3-Clause "New" or "Revised" License
7 stars 21 forks source link

ADAravis does not support internal triggering #396

Closed callumforrester closed 5 days ago

callumforrester commented 2 weeks ago

ADAravis detectors cannot be counted as they don't support internal triggering:

ERROR:blueapi.cli.cli:<AsyncStatus, task: <coroutine object StandardDetector.trigger at 0x7feb33ea7840>, errored: ValueError("AravisController only supports the following trigger types: (<DetectorTrigger.constant_gate: 'constant_gate'>, <DetectorTrigger.edge_trigger: 'edge_trigger'>) but was asked to use DetectorTrigger.internal")>
olliesilvester commented 5 days ago

I ran into this issue as well. For my work-around, I made the Aravis detector device override trigger, so that it sets the trigger type to constant_gate by default

coretl commented 5 days ago

This is a simple bug: https://github.com/bluesky/ophyd-async/blob/f8009fdd6b8258bcbc4bf7a69e342a03994c42f9/src/ophyd_async/epics/areadetector/controllers/aravis_controller.py#L62-L72

Should have DetectorTrigger.internal in supported_trigger_types